fix: mark the intermediary archive of shared libraries as alwayslink #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerisier
force-pushed
the
cerisier/passthrough-shared-library-with-cc
branch
from
93fe648 to
c8cefbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archives are treated differently from object files by the linker.
Object files are unconditionally linked while objects within archives are loaded based on symbol reference from previously listed objects.
Because we use a transitory archive that we then link into a shared library. That archive MUST be linked as
--whole-archive(or-force_loadon macOS).I've added a failing test first then the fix which makes the test pass.