lint-tests

internal/config/config_test.go

@@ -12,7 +12,11 @@ import (
 )
 
 func TestLoadDefaults(t *testing.T) {
-	// Load config without a config file present
+	// Point HOME at an empty temp dir so no real config file is found.
+	t.Setenv("HOME", t.TempDir())
+	homedir.DisableCache = true
+	t.Cleanup(func() { homedir.DisableCache = false })
+
 	cfg, err := Load()
 	require.NoError(t, err)
 	require.NotNil(t, cfg)

internal/git/root_test.go

@@ -32,19 +32,21 @@ func initGitRepo(t *testing.T, dir string) {
 }
 
 func TestFindRoot_ReturnsRepoRoot(t *testing.T) {
-	dir := t.TempDir()
+	dir, err := filepath.EvalSymlinks(t.TempDir())
+	require.NoError(t, err)
 	initGitRepo(t, dir)
 
 	got := FindRoot(dir)
 	assert.Equal(t, dir, got)
 }
 
 func TestFindRoot_Subdir_ReturnsRepoRoot(t *testing.T) {
-	dir := t.TempDir()
+	dir, err := filepath.EvalSymlinks(t.TempDir())
+	require.NoError(t, err)
 	initGitRepo(t, dir)
 
 	subdir := filepath.Join(dir, "some", "nested", "subdir")
-	err := os.MkdirAll(subdir, 0o755)
+	err = os.MkdirAll(subdir, 0o755)
 	require.NoError(t, err)
 
 	got := FindRoot(subdir)

internal/vm/oauth_relay_darwin.go

@@ -101,6 +101,6 @@ func startOAuthRelay(done <-chan struct{}, bootstrapDir string, port string) err
 		_ = srv.Shutdown(ctx)
 	}()
 
-	go srv.Serve(ln)
+	go func() { _ = srv.Serve(ln) }()
 	return nil
 }

internal/vm/oauth_relay_test.go

@@ -118,7 +118,7 @@ func TestStartOAuthRelay(t *testing.T) {
 		t.Fatal(err)
 	}
 	port := ln.Addr().(*net.TCPAddr).Port
-	ln.Close()
+	_ = ln.Close()
 
 	tmpDir := t.TempDir()
 	done := make(chan struct{})
@@ -134,7 +134,7 @@ func TestStartOAuthRelay(t *testing.T) {
 	if err != nil {
 		t.Fatalf("GET: %v", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
 		t.Errorf("status = %d, want 200", resp.StatusCode)
@@ -158,7 +158,7 @@ func TestStartOAuthRelayPortConflict(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer ln.Close()
+	defer func() { _ = ln.Close() }()
 
 	port := ln.Addr().(*net.TCPAddr).Port
 	portStr := fmt.Sprintf("%d", port)