This repository was archived by the owner on Sep 8, 2023. It is now read-only.
Fix non-fatal error when using the --clone parameter #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all of hidden repo files were moved to data mount directory, which later resulted rmdir complaining about the directory to-be-deleted still containing some files. It's surprisingly tricky to simply move all files and folders without any mv errors when using POSIX. This fix is shamelessly stolen from https://unix.stackexchange.com/questions/6393/how-do-you-move-all-files-including-hidden-from-one-directory-to-another/6397#6397
|
Hello, @rhssk! I'm not quite sure I understand what benefit this brings. Currenty only the hidden files that start with |
|
When using the It would be cleaner if all repo files were copied and script doesn't exit with 1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
Previous code suspiciously looks like it was intended to only move hidden files starting with
.git. If that was really the reason (I can't imagine why though) a different approach might be needed.Cheers