Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error during calculation of average transaction amount of recurrences #148

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

simhnna
Copy link
Contributor

@simhnna simhnna commented Dec 23, 2022

It used to throw for recurrences that have no linked transactions

Fixes: #147

…nces

It used to throw for recurrences that have no linked transactions

Fixes: #147
@simhnna simhnna enabled auto-merge December 23, 2022 12:05
@simhnna simhnna force-pushed the fix-recurrence-average-amount branch from ebce37c to 14c1339 Compare December 23, 2022 12:06
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 74.70% // Head: 82.67% // Increases project coverage by +7.97% 🎉

Coverage data is based on head (14c1339) compared to base (09f27ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   74.70%   82.67%   +7.97%     
==========================================
  Files          38       53      +15     
  Lines        1866     2719     +853     
==========================================
+ Hits         1394     2248     +854     
+ Misses        472      471       -1     
Impacted Files Coverage Δ
silverstrike/models/recurrence.py 85.38% <100.00%> (+0.34%) ⬆️
silverstrike/tests/models/test_recurrences.py 100.00% <100.00%> (ø)
silverstrike/tests/models/test_transactions.py 100.00% <0.00%> (ø)
...ike/tests/forms/test_recurringtransaction_forms.py 100.00% <0.00%> (ø)
silverstrike/tests/views/test_account_views.py 100.00% <0.00%> (ø)
silverstrike/tests/models/test_splits.py 100.00% <0.00%> (ø)
...rstrike/tests/views/test_update_recurrence_date.py 100.00% <0.00%> (ø)
silverstrike/tests/views/test_views.py 100.00% <0.00%> (ø)
silverstrike/tests/models/test_categories.py 100.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simhnna simhnna disabled auto-merge December 23, 2022 12:09
@simhnna simhnna merged commit d91c4b9 into master Dec 23, 2022
@simhnna simhnna deleted the fix-recurrence-average-amount branch December 23, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500 on recurrences
1 participant