Support native python enum generation#446
Merged
sheinbergon merged 33 commits intoagronholm:masterfrom Jan 18, 2026
Merged
Conversation
Owner
|
Looks like there's a coverage drop. Can that be resolved? |
Collaborator
Author
Ah, probably after my recent amendments to this PR. Sure, I'll fix them and ping you |
Collaborator
Author
|
@agronholm can you have a look now? |
75d603e to
ebf4f1b
Compare
Owner
|
I'll review this tomorrow. |
Collaborator
Author
|
@agronholm did you have a chance to review this PR? |
Owner
|
Doing that now. |
agronholm
requested changes
Jan 8, 2026
Owner
agronholm
left a comment
There was a problem hiding this comment.
Some change requests, questions and comments.
agronholm
reviewed
Jan 9, 2026
agronholm
reviewed
Jan 9, 2026
agronholm
requested changes
Jan 9, 2026
Owner
agronholm
left a comment
There was a problem hiding this comment.
Hopefully this is the last round.
agronholm
reviewed
Jan 9, 2026
agronholm
approved these changes
Jan 9, 2026
Added PR credit for enum generation feature.
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
for more information, see https://pre-commit.ci
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
c26f283 to
3fa2332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #408
Adds Python enum generation for database enum types
Native database ENUMs
Regarding Synthetic ENUMs for VARCHAR columns with CHECK Constraints
Generated Code
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.