Skip to content

Support external python-types#428

Merged
sheinbergon merged 10 commits intoagronholm:masterfrom
sheinbergon:sheinbergon/not-implemented-python-type-handling
Sep 4, 2025
Merged

Support external python-types#428
sheinbergon merged 10 commits intoagronholm:masterfrom
sheinbergon:sheinbergon/not-implemented-python-type-handling

Conversation

@sheinbergon
Copy link
Collaborator

@sheinbergon sheinbergon commented Aug 28, 2025

Changes

Fixes #423, #430

Adds a fallback for NotImplemented python_type errors, including test coverage using geoalchemy2

NOTICE: The test does not cover python 3.9, as geoalchemy2 dropped support for python 3.9 in its latest release and changed some other default behavior. As python 3.9 will soon reach EOL, I so no point in trying to cover it.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • You've added a new changelog entry (in CHANGES.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/sqlacodegen/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@sheinbergon sheinbergon added this to the 3.1.1 milestone Aug 28, 2025
@sheinbergon sheinbergon requested a review from agronholm August 28, 2025 19:32
@sheinbergon sheinbergon force-pushed the sheinbergon/not-implemented-python-type-handling branch from 2b9bc57 to aba66ba Compare August 28, 2025 19:38
@sheinbergon
Copy link
Collaborator Author

@agronholm I'm working to fix python 3.9 compatbility. As this regression is breaking, I'd like to release it as 3.1.1 as soon as we merge. That's why the CHANGES.rst already maps to 3.1.1

@coveralls
Copy link

coveralls commented Aug 28, 2025

Coverage Status

coverage: 97.887% (+0.2%) from 97.671%
when pulling 87fe865 on sheinbergon:sheinbergon/not-implemented-python-type-handling
into 9c7477b on agronholm:master.

@sheinbergon
Copy link
Collaborator Author

sheinbergon commented Aug 28, 2025

@agronholm - The test does not cover python 3.9, as geoalchemy2 dropped support for python 3.9 in its latest release and changed some other default behavior. As python 3.9 will soon reach EOL, I see no point in trying to cover it.

@sheinbergon sheinbergon force-pushed the sheinbergon/not-implemented-python-type-handling branch from 699af89 to 07eb368 Compare September 1, 2025 20:57
@sheinbergon sheinbergon merged commit a1f22fc into agronholm:master Sep 4, 2025
8 checks passed
@sheinbergon
Copy link
Collaborator Author

@agronholm can you push the 3.1.1 tag?

@agronholm
Copy link
Owner

I did that now. What happens if you try to push a tag?

@sheinbergon
Copy link
Collaborator Author

I don't think I can. I'll try in the next release 🙏

@sheinbergon sheinbergon deleted the sheinbergon/not-implemented-python-type-handling branch September 4, 2025 09:49
@agronholm
Copy link
Owner

You can try pushing a non-numeric tag, as those will not trigger the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible issue with 3.1.0 and sqlacodegen[geoalchemy2]

3 participants