Support external python-types#428
Merged
sheinbergon merged 10 commits intoagronholm:masterfrom Sep 4, 2025
Merged
Conversation
2b9bc57 to
aba66ba
Compare
Collaborator
Author
|
@agronholm I'm working to fix python 3.9 compatbility. As this regression is breaking, I'd like to release it as 3.1.1 as soon as we merge. That's why the CHANGES.rst already maps to 3.1.1 |
Collaborator
Author
|
@agronholm - The test does not cover python 3.9, as geoalchemy2 dropped support for python 3.9 in its latest release and changed some other default behavior. As python 3.9 will soon reach EOL, I see no point in trying to cover it. |
2 tasks
agronholm
requested changes
Aug 29, 2025
agronholm
reviewed
Sep 1, 2025
agronholm
reviewed
Sep 1, 2025
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
699af89 to
07eb368
Compare
agronholm
reviewed
Sep 1, 2025
agronholm
approved these changes
Sep 2, 2025
Collaborator
Author
|
@agronholm can you push the 3.1.1 tag? |
Owner
|
I did that now. What happens if you try to push a tag? |
Collaborator
Author
|
I don't think I can. I'll try in the next release 🙏 |
Owner
|
You can try pushing a non-numeric tag, as those will not trigger the release process. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #423, #430
Adds a fallback for
NotImplementedpython_type errors, including test coverage using geoalchemy2NOTICE: The test does not cover python 3.9, as geoalchemy2 dropped support for python 3.9 in its latest release and changed some other default behavior. As python 3.9 will soon reach EOL, I so no point in trying to cover it.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.