You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues and didn't find my feature already requested there
Feature description
Currently, PatchedTracebackException overrides the stdlib TracebackException implementation of format and format_exception_only. With the new pyrepl coming in python3.13, the signatures of those methods changes: they get an additional kwarg colorize. In PyPy we would like to backport that pure-python pyrepl to our python3.10 implementation, but then the overrides' signatures are wrong. Adding **kwargs would future-proof the overrides, at the cost of loosing the nice colorization of tracebacks.
Use case
This came up in pypy/pypy#5004, where pytest collection suddenly started failing. There may be other cases for using exceptiongroups on Python implementations and versions that change the signatures of the overriden functions.
The text was updated successfully, but these errors were encountered:
Hm, I looked at the signatures of the stdlib counterparts and, to my surprise, they too had **kwargs there. I'm working on a PR to address this, but I'm getting test failures to do the exception note being present in the output twice. I'll post the PR as soon as I've resolved this.
Things to check first
Feature description
Currently,
PatchedTracebackException
overrides the stdlibTracebackException
implementation offormat
andformat_exception_only
. With the new pyrepl coming in python3.13, the signatures of those methods changes: they get an additional kwargcolorize
. In PyPy we would like to backport that pure-python pyrepl to our python3.10 implementation, but then the overrides' signatures are wrong. Adding**kwargs
would future-proof the overrides, at the cost of loosing the nice colorization of tracebacks.Use case
This came up in pypy/pypy#5004, where pytest collection suddenly started failing. There may be other cases for using exceptiongroups on Python implementations and versions that change the signatures of the overriden functions.
The text was updated successfully, but these errors were encountered: