-
Notifications
You must be signed in to change notification settings - Fork 149
Fixed getaddrinfo tests failing #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:97
- Appending host entries with tee -a may introduce duplicate lines on subsequent runs. Consider checking if the entry exists before adding to avoid potential conflicts.
echo "1.2.3.4 xn--fa-hia.de" | sudo tee -a /etc/hosts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:97
- [nitpick] Consider checking if the entry '1.2.3.4 xn--fa-hia.de' is already present before appending to /etc/hosts to avoid duplicate entries on repeated workflow runs.
echo "1.2.3.4 xn--fa-hia.de" | sudo tee -a /etc/hosts
Add-Content -Path C:\Windows\System32\drivers\etc\hosts -Value "1.2.3.4 xn--fa-hia.de" | ||
Add-Content -Path C:\Windows\System32\drivers\etc\hosts -Value "5.6.7.8 fass.de" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider checking if the entry '1.2.3.4 xn--fa-hia.de' is already present in the Windows hosts file before appending to prevent duplicate entries on repeated runs.
Add-Content -Path C:\Windows\System32\drivers\etc\hosts -Value "1.2.3.4 xn--fa-hia.de" | |
Add-Content -Path C:\Windows\System32\drivers\etc\hosts -Value "5.6.7.8 fass.de" | |
if (-not (Select-String -Path C:\Windows\System32\drivers\etc\hosts -Pattern "1.2.3.4 xn--fa-hia.de")) { | |
Add-Content -Path C:\Windows\System32\drivers\etc\hosts -Value "1.2.3.4 xn--fa-hia.de" | |
} | |
if (-not (Select-String -Path C:\Windows\System32\drivers\etc\hosts -Pattern "5.6.7.8 fass.de")) { | |
Add-Content -Path C:\Windows\System32\drivers\etc\hosts -Value "5.6.7.8 fass.de" | |
} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Changes
Fixes sporadically failing
test_getaddrinfo()
due to external DNS issues.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/
) added which would fail without your patchdocs/
, in case of behavior changes or newfeatures)
docs/versionhistory.rst
).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**
as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.