avoid refcycles in tracebacks from happy eyeballs exceptions #809

graingert · 2024-10-13T11:19:33Z

Changes

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

You've added tests (in tests/) added which would fail without your patch
You've updated the documentation (in docs/, in case of behavior changes or new
features)
You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

tests/test_sockets.py

graingert · 2024-10-13T13:00:53Z

This is failing on Python3.9 because anyio is using asyncio.get_running_loop().create_connection() which in 3.9 didn't delete its reference to exceptions I think it should use sock.bind() + asyncio.get_running_loop().sock_connect instead.

src/anyio/_core/_sockets.py

for more information, see https://pre-commit.ci

pyproject.toml

for more information, see https://pre-commit.ci

tests/test_sockets.py

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>

for more information, see https://pre-commit.ci

tests/test_sockets.py

agronholm

Just a couple nits.

src/anyio/_core/_sockets.py

tests/test_sockets.py

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>

…ns/codecov-cli with 2 updates (#581) Bumps the python-dependencies group in /.github/actions/codecov-cli with 2 updates: [codecov-cli](https://github.com/codecov/codecov-cli) and [anyio](https://github.com/agronholm/anyio). Updates `codecov-cli` from 10.2.0 to 10.3.0 <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/codecov/codecov-cli/releases">codecov-cli's releases</a>. <blockquote> <h2>Release v10.3.0</h2> Autogenerated for v10.3.0. Created for <a href="https://redirect.github.com/codecov/codecov-cli/pull/666">codecov/codecov-cli#666</a> <h2>What's Changed</h2> <ul> <li>Release 10.2.0 by <a href="https://github.com/codecov-releaser"><code>@codecov-releaser</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/652">codecov/codecov-cli#652</a></li> <li>Add create commit to <code>empty-upload</code> command by <a href="https://github.com/michelletran-codecov"><code>@michelletran-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/654">codecov/codecov-cli#654</a></li> <li>Release 10.2.1 by <a href="https://github.com/codecov-releaser"><code>@codecov-releaser</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/655">codecov/codecov-cli#655</a></li> <li>Pin requirements.txt to use test-results-parser==0.5.4 by <a href="https://github.com/michelletran-codecov"><code>@michelletran-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/656">codecov/codecov-cli#656</a></li> <li>Revert "Release 10.2.1" by <a href="https://github.com/michelletran-codecov"><code>@michelletran-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/657">codecov/codecov-cli#657</a></li> <li>Release 10.2.1 by <a href="https://github.com/codecov-releaser"><code>@codecov-releaser</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/658">codecov/codecov-cli#658</a></li> <li>Hide and mark ATS-related commands as deprecated by <a href="https://github.com/Swatinem"><code>@Swatinem</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/662">codecov/codecov-cli#662</a></li> <li>fix: add list_relevant_files to NoVersioningSystem by <a href="https://github.com/thomasrockhu-codecov"><code>@thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/665">codecov/codecov-cli#665</a></li> </ul> Full Changelog: <a href="https://github.com/codecov/codecov-cli/compare/v10.2.0...v10.3.0">https://github.com/codecov/codecov-cli/compare/v10.2.0...v10.3.0</a> <h2>Release v10.2.1</h2> Autogenerated for v10.2.1. Created for <a href="https://redirect.github.com/codecov/codecov-cli/pull/658">codecov/codecov-cli#658</a> <h2>What's Changed</h2> <ul> <li>Release 10.1.1 by <a href="https://github.com/codecov-releaser"><code>@codecov-releaser</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/645">codecov/codecov-cli#645</a></li> <li>add --toc-recurse-submodules argument by <a href="https://github.com/matt-codecov"><code>@matt-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/650">codecov/codecov-cli#650</a></li> <li>Release 10.2.0 by <a href="https://github.com/codecov-releaser"><code>@codecov-releaser</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/652">codecov/codecov-cli#652</a></li> <li>Add create commit to <code>empty-upload</code> command by <a href="https://github.com/michelletran-codecov"><code>@michelletran-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/654">codecov/codecov-cli#654</a></li> <li>Release 10.2.1 by <a href="https://github.com/codecov-releaser"><code>@codecov-releaser</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/655">codecov/codecov-cli#655</a></li> <li>Pin requirements.txt to use test-results-parser==0.5.4 by <a href="https://github.com/michelletran-codecov"><code>@michelletran-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/656">codecov/codecov-cli#656</a></li> <li>Revert "Release 10.2.1" by <a href="https://github.com/michelletran-codecov"><code>@michelletran-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-cli/pull/657">codecov/codecov-cli#657</a></li> </ul> Full Changelog: <a href="https://github.com/codecov/codecov-cli/compare/v10.1.1...v10.2.1">https://github.com/codecov/codecov-cli/compare/v10.1.1...v10.2.1</a> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-cli/commit/97e90fa9fff4ab9d4f39217b320f5375bf754aba"><code>97e90fa</code></a> Prepare release 10.3.0</li> <li><a href="https://github.com/codecov/codecov-cli/commit/f2b75b3183b4bd1e203f415e5e16b82cc5e62bb9"><code>f2b75b3</code></a> fix: add list_relevant_files to NoVersioningSystem (<a href="https://redirect.github.com/codecov/codecov-cli/issues/665">#665</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/6533a8c9d8b9f336aaaef8919459bdf5013ed852"><code>6533a8c</code></a> Hide and mark ATS-related commands as deprecated (<a href="https://redirect.github.com/codecov/codecov-cli/issues/662">#662</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/8364881cde4cd111bc2caca137a97e57f3ef1543"><code>8364881</code></a> Prepare release 10.2.1 (<a href="https://redirect.github.com/codecov/codecov-cli/issues/658">#658</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/29a7964f9b47541a79e6ec5dee97eb81b73c7cf7"><code>29a7964</code></a> Revert "Prepare release 10.2.1 (<a href="https://redirect.github.com/codecov/codecov-cli/issues/655">#655</a>)" (<a href="https://redirect.github.com/codecov/codecov-cli/issues/657">#657</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/852ad85e9ef0f2f613ac9bdf2a5825e79786af4a"><code>852ad85</code></a> Pin requirements.txt to use test-results-parser==0.5.4 (<a href="https://redirect.github.com/codecov/codecov-cli/issues/656">#656</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/aed3a0473e7bc9b5b62d1753e59de0cab0a9c9ec"><code>aed3a04</code></a> Prepare release 10.2.1 (<a href="https://redirect.github.com/codecov/codecov-cli/issues/655">#655</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/30cba3fd3b047bb4c1f2295201568ca458a74cc4"><code>30cba3f</code></a> Add create commit to <code>empty-upload</code> command (<a href="https://redirect.github.com/codecov/codecov-cli/issues/654">#654</a>)</li> <li><a href="https://github.com/codecov/codecov-cli/commit/079f01ba314c9ed0fdf7f5ef0699fe17be9c250f"><code>079f01b</code></a> Prepare release 10.2.0 (<a href="https://redirect.github.com/codecov/codecov-cli/issues/652">#652</a>)</li> <li>See full diff in <a href="https://github.com/codecov/codecov-cli/compare/v10.2.0...v10.3.0">compare view</a></li> </ul> </details> Updates `anyio` from 4.8.0 to 4.9.0 <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/agronholm/anyio/releases">anyio's releases</a>. <blockquote> <h2>4.9.0</h2> <ul> <li>Added async support for temporary file handling (<a href="https://redirect.github.com/agronholm/anyio/issues/344">#344</a>; PR by <a href="https://github.com/11kkw"><code>@11kkw</code></a>)</li> <li>Added 4 new fixtures for the AnyIO <code>pytest</code> plugin: <ul> <li><code>free_tcp_port_factory</code>: session scoped fixture returning a callable that generates unused TCP port numbers</li> <li><code>free_udp_port_factory</code>: session scoped fixture returning a callable that generates unused UDP port numbers</li> <li><code>free_tcp_port</code>: function scoped fixture that invokes the <code>free_tcp_port_factory</code> fixture to generate a free TCP port number</li> <li><code>free_udp_port</code>: function scoped fixture that invokes the <code>free_udp_port_factory</code> fixture to generate a free UDP port number</li> </ul> </li> <li>Added <code>stdin</code> argument to <code>anyio.run_process()</code> akin to what <code>anyio.open_process()</code>, <code>asyncio.create_subprocess()</code>, <code>trio.run_process()</code>, and <code>subprocess.run()</code> already accept (PR by <a href="https://github.com/jmehnle"><code>@jmehnle</code></a>)</li> <li>Added the <code>info</code> property to <code>anyio.Path</code> on Python 3.14</li> <li>Changed <code>anyio.getaddrinfo()</code> to ignore (invalid) IPv6 name resolution results when IPv6 support is disabled in Python</li> <li>Changed <code>EndOfStream</code> raised from <code>MemoryObjectReceiveStream.receive()</code> to leave out the <code>AttributeError</code> from the exception chain which was merely an implementation detail and caused some confusion</li> <li>Fixed traceback formatting growing quadratically with level of <code>TaskGroup</code> nesting on asyncio due to exception chaining when raising <code>ExceptionGroups</code> in <code>TaskGroup.__aexit__</code> (<a href="https://redirect.github.com/agronholm/anyio/issues/863">#863</a>; PR by <a href="https://github.com/tapetersen"><code>@tapetersen</code></a>)</li> <li>Fixed <code>anyio.Path.iterdir()</code> making a blocking call in Python 3.13 (<a href="https://redirect.github.com/agronholm/anyio/issues/873">#873</a>; PR by <a href="https://github.com/cbornet"><code>@cbornet</code></a> and <a href="https://github.com/agronholm"><code>@agronholm</code></a>)</li> <li>Fixed <code>connect_tcp()</code> producing cyclic references in tracebacks when raising exceptions (<a href="https://redirect.github.com/agronholm/anyio/pull/809">#809</a>; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed <code>anyio.to_thread.run_sync()</code> needlessly holding on to references of the context, function, arguments and others until the next work item on asyncio (PR by <a href="https://github.com/Wankupi"><code>@Wankupi</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/agronholm/anyio/blob/master/docs/versionhistory.rst">anyio's changelog</a>. <blockquote> <h1>Version history</h1> This library adheres to <code>Semantic Versioning 2.0 <http://semver.org/></code>_. 4.9.0 <ul> <li> Added async support for temporary file handling (<code>[#344](agronholm/anyio#344) <https://github.com/agronholm/anyio/issues/344></code>_; PR by <a href="https://github.com/11kkw"><code>@11kkw</code></a>) </li> <li> Added 4 new fixtures for the AnyIO <code>pytest</code> plugin: <ul> <li><code>free_tcp_port_factory</code>: session scoped fixture returning a callable that generates unused TCP port numbers</li> <li><code>free_udp_port_factory</code>: session scoped fixture returning a callable that generates unused UDP port numbers</li> <li><code>free_tcp_port</code>: function scoped fixture that invokes the <code>free_tcp_port_factory</code> fixture to generate a free TCP port number</li> <li><code>free_udp_port</code>: function scoped fixture that invokes the <code>free_udp_port_factory</code> fixture to generate a free UDP port number</li> </ul> </li> <li> Added <code>stdin</code> argument to <code>anyio.run_process()</code> akin to what <code>anyio.open_process()</code>, <code>asyncio.create_subprocess_…()</code>, <code>trio.run_process()</code>, and <code>subprocess.run()</code> already accept (PR by <a href="https://github.com/jmehnle"><code>@jmehnle</code></a>) </li> <li> Added the <code>info</code> property to <code>anyio.Path</code> on Python 3.14 </li> <li> Changed <code>anyio.getaddrinfo()</code> to ignore (invalid) IPv6 name resolution results when IPv6 support is disabled in Python </li> <li> Changed <code>EndOfStream</code> raised from <code>MemoryObjectReceiveStream.receive()</code> to leave out the <code>AttributeError</code> from the exception chain which was merely an implementation detail and caused some confusion </li> <li> Fixed traceback formatting growing quadratically with level of <code>TaskGroup</code> nesting on asyncio due to exception chaining when raising <code>ExceptionGroups</code> in <code>TaskGroup.__aexit__</code> (<code>[#863](agronholm/anyio#863) <https://github.com/agronholm/anyio/issues/863></code>_; PR by <a href="https://github.com/tapetersen"><code>@tapetersen</code></a>) </li> <li> Fixed <code>anyio.Path.iterdir()</code> making a blocking call in Python 3.13 (<code>[#873](agronholm/anyio#873) <https://github.com/agronholm/anyio/issues/873></code>_; PR by <a href="https://github.com/cbornet"><code>@cbornet</code></a> and <a href="https://github.com/agronholm"><code>@agronholm</code></a>) </li> <li> Fixed <code>connect_tcp()</code> producing cyclic references in tracebacks when raising exceptions (<code>[#809](agronholm/anyio#809) <https://github.com/agronholm/anyio/pull/809></code>_; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>) </li> <li> Fixed <code>anyio.to_thread.run_sync()</code> needlessly holding on to references of the context, function, arguments and others until the next work item on asyncio (PR by <a href="https://github.com/Wankupi"><code>@Wankupi</code></a>) </li> </ul> 4.8.0 <ul> <li>Added experimental support for running functions in subinterpreters on Python 3.13 and later</li> <li>Added support for the <code>copy()</code>, <code>copy_into()</code>, <code>move()</code> and <code>move_into()</code> methods in <code>anyio.Path</code>, available in Python 3.14</li> <li>Changed <code>TaskGroup</code> on asyncio to always spawn tasks non-eagerly, even if using a task factory created via <code>asyncio.create_eager_task_factory()</code>, to preserve expected Trio-like task scheduling semantics (PR by <a href="https://github.com/agronholm"><code>@agronholm</code></a> and <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> </ul>  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/agronholm/anyio/commit/a6e9ebb75f0e1492ab5d0740b2ca76d0137f95e3"><code>a6e9ebb</code></a> Bumped up the version</li> <li><a href="https://github.com/agronholm/anyio/commit/9b9520d9ab3b00c0438073278830eddb64ff7875"><code>9b9520d</code></a> Fixed cyclic references in to_thread.run_sync() on asyncio (<a href="https://redirect.github.com/agronholm/anyio/issues/887">#887</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/1f04d6b1582f21bc199417ffcd46f78defbc0ec9"><code>1f04d6b</code></a> Added a note about asyncio cancellation semantics</li> <li><a href="https://github.com/agronholm/anyio/commit/e14b17208982aaa90158038a66eb0696fe7bd548"><code>e14b172</code></a> Upgraded to a newer Sphinx version</li> <li><a href="https://github.com/agronholm/anyio/commit/7e13c49b34e908980a1198e9b05f43677dab833a"><code>7e13c49</code></a> Avoid refcycles in tracebacks from happy eyeballs exceptions (<a href="https://redirect.github.com/agronholm/anyio/issues/809">#809</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/d134da712b884efc19894966421894da4dab1c86"><code>d134da7</code></a> Raise EndOfStream from None in MemoryObjectReceiveStream.receive() (<a href="https://redirect.github.com/agronholm/anyio/issues/889">#889</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/2840e06384d22f35935874043a753d04b0fad70c"><code>2840e06</code></a> Added cheaper implementation for no_other_refs() on Python 3.14 (<a href="https://redirect.github.com/agronholm/anyio/issues/886">#886</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/31ce0a5d7532b9148570194c2a934741bbed2cad"><code>31ce0a5</code></a> Added fixtures for generating bindable TCP/UDP ports (<a href="https://redirect.github.com/agronholm/anyio/issues/856">#856</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/cd85e47338a32e6eb813998c4b1c8dbf0b9f722b"><code>cd85e47</code></a> Test on PyPy 3.11 on CI (<a href="https://redirect.github.com/agronholm/anyio/issues/876">#876</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/d228020e6ea3f3b0bb8eab3a75eb1df31389eddf"><code>d228020</code></a> Detect blocking calls in coroutines using BlockBuster (<a href="https://redirect.github.com/agronholm/anyio/issues/875">#875</a>)</li> <li>Additional commits viewable in <a href="https://github.com/agronholm/anyio/compare/4.8.0...4.9.0">compare view</a></li> </ul> </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

graingert added 2 commits October 13, 2024 12:21

avoid refcycles in happy eyeballs

272d59c

update history

c217d95

graingert force-pushed the happy-eyeballs-cyclic-garbage branch from 41264d3 to c217d95 Compare October 13, 2024 11:22

graingert added 2 commits October 13, 2024 12:41

can't clear oserrors

9b46a18

specify only v4

222c6cd

graingert commented Oct 13, 2024

View reviewed changes

tests/test_sockets.py Show resolved Hide resolved

fix on trio on py < 3.13

a2baf53

graingert force-pushed the happy-eyeballs-cyclic-garbage branch from bd67006 to a2baf53 Compare October 13, 2024 12:20

graingert mentioned this pull request Oct 13, 2024

KI protection f_locals materialization results in reference cycles on 3.12 and below python-trio/trio#3108

Closed

Merge branch 'master' into happy-eyeballs-cyclic-garbage

06c77dc

graingert commented Jan 7, 2025

View reviewed changes

src/anyio/_core/_sockets.py Show resolved Hide resolved

graingert commented Jan 7, 2025

View reviewed changes

src/anyio/_core/_sockets.py Outdated Show resolved Hide resolved

graingert and others added 4 commits January 7, 2025 09:18

Apply suggestions from code review

2387f99

[pre-commit.ci] auto fixes from pre-commit.com hooks

0203d03

for more information, see https://pre-commit.ci

fixes after merge

6fba791

add ephemeral-port-reserve again

6dd2010

graingert commented Jan 7, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

graingert and others added 3 commits January 7, 2025 09:29

Update pyproject.toml

877855e

skip on 3.9 asyncio

4bb150d

[pre-commit.ci] auto fixes from pre-commit.com hooks

4eea30f

for more information, see https://pre-commit.ci

graingert commented Jan 7, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

graingert added 2 commits January 7, 2025 09:38

Update tests/test_sockets.py

7ddcd12

news

0542d94

graingert commented Jan 7, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

Update tests/test_sockets.py

e53e9eb

graingert marked this pull request as ready for review January 7, 2025 09:51

graingert requested a review from agronholm January 7, 2025 09:52

agronholm reviewed Jan 7, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

remove ephemeral-port-reserve

3d626c9

agronholm reviewed Jan 7, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

agronholm reviewed Jan 7, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

Update tests/test_sockets.py

05d9f63

agronholm reviewed Jan 7, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

graingert and others added 7 commits March 12, 2025 15:11

Merge branch 'master' into happy-eyeballs-cyclic-garbage

72c8b93

Update tests/test_sockets.py

fa77dd2

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>

Merge branch 'master' into happy-eyeballs-cyclic-garbage

480b4f8

Merge branch 'master' into happy-eyeballs-cyclic-garbage

c198531

move no_other_refs

98f0db8

use free_tcp_port

a637d4b

[pre-commit.ci] auto fixes from pre-commit.com hooks

d1d0e30

for more information, see https://pre-commit.ci

graingert commented Mar 12, 2025

View reviewed changes

tests/test_sockets.py Outdated Show resolved Hide resolved

graingert and others added 3 commits March 12, 2025 16:45

fix ip NamedError

4fe9de3

Reformatted the changelog entry

3c99108

use free_tcp_port in test_connection_refused

f167b6f

agronholm approved these changes Mar 16, 2025

View reviewed changes

src/anyio/_core/_sockets.py Outdated Show resolved Hide resolved

tests/test_sockets.py Outdated Show resolved Hide resolved

graingert and others added 2 commits March 16, 2025 12:23

Update tests/test_sockets.py

4f9ff5b

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>

Update src/anyio/_core/_sockets.py

fe79118

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>

agronholm merged commit 7e13c49 into master Mar 16, 2025
31 of 32 checks passed

agronholm deleted the happy-eyeballs-cyclic-garbage branch March 16, 2025 12:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

avoid refcycles in tracebacks from happy eyeballs exceptions #809

avoid refcycles in tracebacks from happy eyeballs exceptions #809

graingert commented Oct 13, 2024 •

edited

Loading

graingert commented Oct 13, 2024

agronholm left a comment

avoid refcycles in tracebacks from happy eyeballs exceptions #809

avoid refcycles in tracebacks from happy eyeballs exceptions #809

Conversation

graingert commented Oct 13, 2024 • edited Loading

Changes

Checklist

Updating the changelog

graingert commented Oct 13, 2024

agronholm left a comment

Choose a reason for hiding this comment

graingert commented Oct 13, 2024 •

edited

Loading