Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: rows with sub-address in 'street' field returns with geocode score of zero #108

Closed
2 tasks done
gregbunce opened this issue Dec 29, 2021 · 2 comments · Fixed by #109 or #285
Closed
2 tasks done

[Bug]: rows with sub-address in 'street' field returns with geocode score of zero #108

gregbunce opened this issue Dec 29, 2021 · 2 comments · Fixed by #109 or #285
Assignees
Labels
bug Something isn't working

Comments

@gregbunce
Copy link

gregbunce commented Dec 29, 2021

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

App Version

1.5.2

Electron Version

16.0.1

Operating System

Windows

What happened?

records/rows in my .csv file that contained a sub-address in the street field did not geocode and returned with a score of 0. it could be b/c the sub-address was prefixed with a pound (#). Example:

street, zone
81 E 100 N #23, 84535

image

Steps To Reproduce

I generated the list of addresses from the open sgid address points using this query:
select fulladd as street, zipcode as zone from location.address_points limit 50

here's the output .csv from that query:
sample_geocodes.csv

Relevant log output

No response

@gregbunce gregbunce added the bug Something isn't working label Dec 29, 2021
@gregbunce gregbunce changed the title [Bug]: rows with sub-address in street field returns with geocode score of zero [Bug]: rows with sub-address in 'street' field returns with geocode score of zero Dec 29, 2021
@steveoh
Copy link
Member

steveoh commented Dec 29, 2021

Thanks greg! Good find 🔍

This looks like an between our conversion from python to js.

nodejs
image

python
image

steveoh added a commit that referenced this issue Dec 29, 2021
steveoh added a commit that referenced this issue Dec 29, 2021
steveoh added a commit that referenced this issue Jan 3, 2022
@stdavis
Copy link
Member

stdavis commented Jan 3, 2022

Thanks for the catch and report, @gregbunce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Closed
3 participants