Skip to content

Commit

Permalink
Docker: Make warning test insensitive to deprecation warnings (aiidat…
Browse files Browse the repository at this point in the history
…eam#6541)

The Docker image is supposed to configure the profile such that warnings
about using a development version of `aiida-core` and a modern version
of RabbitMQ are silenced. The test was checking that `Warning` did not
appear in the output of `verdi status`, however, this would result in
false positives in case a deprecation warning would be printed due to
downstream dependencies that we cannot necessarily control. The test is
made more specific to check for a line starting with `Warning:` which
should reduce the chance for false positives.
  • Loading branch information
sphuber authored Jul 22, 2024
1 parent 16b8fe4 commit f1be224
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .docker/tests/test_aiida.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
import re

import pytest
from packaging.version import parse
Expand Down Expand Up @@ -32,8 +33,10 @@ def test_verdi_status(aiida_exec, container_user):
assert '✔ broker:' in output
assert 'Daemon is running' in output

# check that we have suppressed the warnings
assert 'Warning' not in output
# Check that we have suppressed the warnings coming from using an install from repo and newer RabbitMQ version.
# Make sure to match only lines that start with ``Warning:`` because otherwise deprecation warnings from other
# packages that we cannot control may fail the test.
assert not re.match('^Warning:.*', output)


def test_computer_setup_success(aiida_exec, container_user):
Expand Down

0 comments on commit f1be224

Please sign in to comment.