Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dragonberry fixes ported from Agoric-ag0 #264

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

JimLarson
Copy link

@JimLarson JimLarson commented Oct 17, 2022

Description

Refs: Agoric/agoric-sdk#6461

Pulls changes from v0.45.4-alpha.agoric.ag0.2 => .3

Will tag as

  • v0.45.4-alpha.agoric.2
  • ics23/go/v0.8.0-alpha.agoric.1

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JimLarson JimLarson added bug Something isn't working agoric-cosmos Agoric tags for cosmos labels Oct 17, 2022
@JimLarson JimLarson self-assigned this Oct 17, 2022
Copy link
Collaborator

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes to existing Agoric branch. I only skimmed the vendored ics23 code, though, since I didn't know what to look for.

@JimLarson
Copy link
Author

The failing test seems to be a known random issue, fixed in cosmos#12374.

@JimLarson JimLarson merged commit 5957efc into Agoric Oct 17, 2022
@JimLarson JimLarson deleted the 6461-dragonberry branch October 17, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos Agoric tags for cosmos bug Something isn't working C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants