Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ranked in list error #62

Merged
merged 3 commits into from
Feb 3, 2017
Merged

Fix ranked in list error #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e099f8
Fix for ranked_in_list_in when using the following options
dcampano Jan 18, 2017
0cda4f7
Include test for include_missing = false and with_member_data = true
dcampano Jan 18, 2017
591a58e
Add test to tie ranking leaderboard spec since we changed code there too
czarneckid Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/leaderboard.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,8 @@ def ranked_in_list_in(leaderboard_name, members, options = {})
end

if leaderboard_options[:with_member_data]
members_data_for_in(leaderboard_name, members).each_with_index do |member_data, index|
included_members = ranks_for_members.collect { |member| member[@member_key] }
members_data_for_in(leaderboard_name, included_members).each_with_index do |member_data, index|
ranks_for_members[index][@member_data_key] = member_data
end
end
Expand Down
5 changes: 3 additions & 2 deletions lib/tie_ranking_leaderboard.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ def ranked_in_list_in(leaderboard_name, members, options = {})
end

if leaderboard_options[:with_member_data]
members_data_for_in(leaderboard_name, members).each_with_index do |member_data, index|
included_members = ranks_for_members.collect { |member| member[@member_key] }
members_data_for_in(leaderboard_name, included_members).each_with_index do |member_data, index|
ranks_for_members[index][@member_data_key] = member_data
end
end
Expand All @@ -278,4 +279,4 @@ def ranked_in_list_in(leaderboard_name, members, options = {})
def ties_leaderboard_key(leaderboard_name)
"#{leaderboard_name}:#{@ties_namespace}"
end
end
end
3 changes: 3 additions & 0 deletions spec/leaderboard_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,5 +851,8 @@
expect(leaders[0][:member]).to eql('member_1')
expect(leaders[1][:member]).to eql('member_15')
expect(leaders[2][:member]).to eql('member_25')

leaders = @leaderboard.ranked_in_list(['member_200'], :include_missing => false, :with_member_data => true)
expect(leaders.size).to be(0)
end
end
3 changes: 3 additions & 0 deletions spec/tie_ranking_leaderboard_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@
expect(leaders[0][:member]).to eql('member_1')
expect(leaders[1][:member]).to eql('member_15')
expect(leaders[2][:member]).to eql('member_25')

leaders = @leaderboard.ranked_in_list(['member_200'], :include_missing => false, :with_member_data => true)
expect(leaders.size).to be(0)
end
end
end