Fix for #60 #61
Closed
Fix for #60 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{:with_member_data => true, :include_missing => false}
|
Thanks. I'll take a look at this PR/issue this week. |
|
I cherry-picked the first 2 commits here for the fix for #60. I didn't end up taking the optimize |
|
Oops, yeah, the optimized around_me wasn't supposed to be part of the pull request. I must have accidentally pushed that. Sorry about that. When I benchmarked that change, it reduced the around_me times by 50%. However, I didn't do the work yet to make it work for the Tie leaderboard and Challenge leaderboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #60. The code wasn't using the filtered members list when setting include_missing to false.