Version 3 proposal: Remove use_zero_index_for_rank_option #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 16, 2012 17:58
Is this ever really used in practice? My guess is no. Although it could be left in as it's not necessarily a lot of code, but it does remove some conditional paths.
Is this ever really used in practice? My guess is no. Although it could be left in as it's not necessarily a lot of code, but it does remove some conditional paths.
|
👍 |
|
This code has been integrated into the version 3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this ever really used in practice? My guess is no. Although it
could be left in as it's not necessarily a lot of code, but it
does remove some conditional paths.