Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the row key names for custom naming schemes. #18

Merged
merged 1 commit into from
Jan 25, 2014

Conversation

seaders
Copy link

@seaders seaders commented Jan 23, 2014

The naming scheme's doesn't fit the rest of our framework's system (a "member" will always be just a "uid", and the "member_data" is "userData" everywhere else), so they're now exposed to be customly overwritten via

Leaderboard.MEMBER_KEY = 'uid'

etc.

@czarneckid
Copy link
Member

I'll integrate this over the next day. Thanks.

czarneckid added a commit to agoragames/leaderboard that referenced this pull request Jan 23, 2014
@seaders
Copy link
Author

seaders commented Jan 23, 2014

Cheers David, thank you for your great work on this library. I had started
writing our own leaderboard library and it was about a day (stupidly)
before I googled for something like this library and when I scanned this,
it was 1000% what I wanted compared to about the 5% of what I'd written
beforehand.

We only implemented the with_member_data bit today, so that's when I saw
that we'd much prefer to have things consistent with the rest of our
framework and made the pull request.

On Thu, Jan 23, 2014 at 1:05 AM, David Czarnecki
notifications@github.comwrote:

I'll integrate this over the next day. Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/18#issuecomment-33087569
.

czarneckid added a commit that referenced this pull request Jan 25, 2014
Expose the row key names for custom naming schemes.
@czarneckid czarneckid merged commit cbd32a1 into agoragames:master Jan 25, 2014
@seaders
Copy link
Author

seaders commented Jan 25, 2014

Awesome, awesome, awesome. Thanks so much David, great library and it's always brilliant when open source maintainers are as quick to respond as you've been.

@czarneckid
Copy link
Member

No problem. Available in 2.7.0, https://pypi.python.org/pypi/leaderboard.

Sorry it took slightly longer to release the latest code, but had to balance that with the Ruby and JavaScript leaderboard libraries. I may make a tweak to the Python library to allow for the key options to be set in the constructor, but that'll be in a patch update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants