Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan iter bug: dev branch #2

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
4397ec4
fix scan iter command issued to different replicas
agnesnatasya Apr 26, 2024
3d5e674
add tests
agnesnatasya Apr 26, 2024
b9d2338
reorder
agnesnatasya Apr 27, 2024
3c1b372
remove ignore
agnesnatasya Apr 27, 2024
cadd357
lint and format
agnesnatasya Apr 27, 2024
e2aa893
better inline
agnesnatasya Apr 29, 2024
1758a9b
backward compatible typing
agnesnatasya Apr 29, 2024
fac2ecd
test inline docs
agnesnatasya May 10, 2024
6751a04
add tests for all scan iter family
agnesnatasya May 10, 2024
f667e34
lint
agnesnatasya May 10, 2024
847ea71
implement in sync client
agnesnatasya Jul 9, 2024
93a2b91
more features for ConnectionsINdexer
agnesnatasya Jul 14, 2024
2f3c887
add _same_addres methods for sentinels
agnesnatasya Jul 14, 2024
992d192
fix connect_to args
agnesnatasya Jul 14, 2024
8d6ca1f
fix tests
agnesnatasya Jul 14, 2024
b2d9d93
add self
agnesnatasya Jul 14, 2024
5838500
convert ConnectionsIndexer to list before indexing
agnesnatasya Jul 14, 2024
e101bdf
convert ConnectionsIndexer to list before indexing
agnesnatasya Jul 14, 2024
96222dd
fix typo
agnesnatasya Jul 14, 2024
3482723
fix
agnesnatasya Jul 14, 2024
ae1b09a
fix connect_to_address
agnesnatasya Jul 14, 2024
6886f71
cleanup in sync client
agnesnatasya Jul 16, 2024
52a1d58
rename kwargs to no underscore for consistency
agnesnatasya Jul 16, 2024
b37fa0c
add cleanup tests for pipeline
agnesnatasya Jul 16, 2024
2f9964e
remove test for pipeline
agnesnatasya Jul 16, 2024
f436f60
lints
agnesnatasya Jul 16, 2024
a2ed1ac
reformat
agnesnatasya Jul 16, 2024
a9f2160
def cleanup in base class
agnesnatasya Jul 16, 2024
6940526
fix some tests
agnesnatasya Jul 16, 2024
e8c7a8b
rename iter_req_id properly
agnesnatasya Jul 16, 2024
dda3b61
fix tests
agnesnatasya Jul 16, 2024
e98c770
set fix address as a property of SentinelManagedConnection
agnesnatasya Jul 19, 2024
e32df58
lint
agnesnatasya Jul 20, 2024
08d3428
make mock class have same behavior as actual class
agnesnatasya Jul 20, 2024
d1db9f6
define _connect_to_sentinel in async server
agnesnatasya Jul 20, 2024
4c59821
mock can_read_destructive for parser
agnesnatasya Jul 20, 2024
25777cf
skip test sentinel managed connection if hirediswq
agnesnatasya Jul 20, 2024
0ee1b85
undo ensure_connection deduplication in BlockingConnectionPool
agnesnatasya Jul 20, 2024
5edff2b
import HIREDIS
agnesnatasya Jul 20, 2024
8d9c735
polymorphism for reset available connections instead
agnesnatasya Jul 20, 2024
c6c7bf7
merge
agnesnatasya Jul 20, 2024
868b499
lint
agnesnatasya Jul 20, 2024
5e249fd
fix inline comments + rename
agnesnatasya Jul 20, 2024
8643185
lint
agnesnatasya Jul 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add self
  • Loading branch information
agnesnatasya committed Jul 16, 2024
commit b2d9d93f0d16bedfe01ce6ddc250d8918553bd77
2 changes: 1 addition & 1 deletion tests/test_asyncio/test_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ async def test_zscan_iter(self, r: redis.Redis):
pairs = [k async for k in r.zscan_iter("a", match="a")]
assert set(pairs) == {(b"a", 1)}

async def test_scan_iter_family_executes_commands_with_same_iter_req_id():
async def test_scan_iter_family_executes_commands_with_same_iter_req_id(self):
"""Assert that all calls to execute_command receives the _iter_req_id kwarg"""
import uuid

Expand Down
2 changes: 1 addition & 1 deletion tests/test_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -2235,7 +2235,7 @@ def test_zscan_iter(self, r):
pairs = list(r.zscan_iter("a", match="a"))
assert set(pairs) == {(b"a", 1)}

def test_scan_iter_family_executes_commands_with_same_iter_req_id():
def test_scan_iter_family_executes_commands_with_same_iter_req_id(self):
"""Assert that all calls to execute_command receives the _iter_req_id kwarg"""
import uuid

Expand Down