Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories with spaces don't get updated correctly #61

Closed
guillaumeboehm opened this issue Feb 9, 2022 · 6 comments
Closed

Directories with spaces don't get updated correctly #61

guillaumeboehm opened this issue Feb 9, 2022 · 6 comments
Assignees

Comments

@guillaumeboehm
Copy link

It seems that jumping into a directory containing spaces adds it to the database but doesn't update it if it is already in the database.

@agkozak
Copy link
Owner

agkozak commented Feb 9, 2022

You're absolutely right. I'll fix this soon. Thanks!

@agkozak agkozak self-assigned this Feb 9, 2022
@agkozak
Copy link
Owner

agkozak commented Feb 10, 2022

@guillaumeboehm,

I just pushed a fix to the develop branch -- would you give that a pull and see if it works for you? Thanks.

@guillaumeboehm
Copy link
Author

This seems to be working just fine now. Actually I realized the match search was a problem too, adding the same fix on line 602 allows to jump to the directory correctly. Sorry I didn't feel like forking to add 3 characters...

@agkozak
Copy link
Owner

agkozak commented Feb 11, 2022

Don't worry - I think there may be a few related problems that I'll want to fix - I'll be happy to make the changes.

But could you give me an example of the "match search" problem? If I type z foo\ bar, it does take me to ~/foo\ bar.

@guillaumeboehm
Copy link
Author

You're right... I'm testing it right now and can't reproduce it either... I don't even know what I was typing when I tested it. Never mind it lol.

agkozak added a commit that referenced this issue Jun 28, 2022
@agkozak
Copy link
Owner

agkozak commented Jun 28, 2022

All right! At long last, I’ve merged the fix to master. Thanks for pointing out the issue.

@agkozak agkozak closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants