Skip to content

Support for other colors? #4

@agilgur5

Description

@agilgur5

Potential downstream request from agilgur5/react-signature-canvas#22

The trimCanvas function would have to accept a second argument for the color and default to transparency detection. Since this hasn't really come up in 2 years and there are alternative ways to achieve the behavior wanted in that issue, I'm not sure that it's worth the added complexity, but I'll document my thoughts here.

In order to be backwards-compatible, the second argument would have to be able to accept wildcards, since right now the function only checks the RGBA alpha transparency if it's not 0 and doesn't even check any of the other RGB parts.

The backwards-compatible wildcard requirement also means one couldn't necessarily just use color-rgba to parse the second argument, unless the default behavior was just kept as different from the arg behavior (as there is no color equivalent to the current check of rgba(*,*,*,0)).

color-rgba is also much larger than this library so that would make an extremely significant size increase, clashing with the existing image of "tiny (< 100 LoC)". Could accept only 'rgba(r,g,b,a)' strings and do some manual parsing instead, but that wouldn't entirely fulfill the downstream issue as there backgroundColor accepts other types of color strings :/ . That would therefore either be incomplete or end up pushing the dependency downstream.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions