deps: remove no longer used changelog-maker devDep
#124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I used [my fork of `changelog-maker`](https://github.com/agilgur5/changelog-maker) for some time, but now my process is more involved - I manually categorize, summarize, and minimize changes - a good chunk of this could be automated by reading the semantic / conventional commit titles, but not entirely (e.g. when a change can fit multiple types or scopes) - I use GitHub Releases' "Generate release notes" feature for the first draft / list of commits + PRs - unlike `changelog-maker`, GH's feature does not require a `PR-URL: <url>` to exist in the commits to be able to reference the PR - I'd like to use a more cross-platform tool that is not reliant on GH, but this is the easiest option right now - removing this outdated devDep also removes any remaining vulns in the devDeps - these didn't affect prod built code and were not exploitable, so were super low priority to fix mainly for less scanner noise Future Work: 1. better automate the changelog 1. make a GH job to publish to NPM and create the GH release - start with manual version bumps for now, but with releases via CI
agilgur5
added
kind: internal
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
@agilgur5/changelog-makerfrom devDeps andscriptsDetails
I used my fork of
changelog-makerfor some time, but now my process is more involvedv1.1.0-alpha.1changelog-maker, GH's feature does not require aPR-URL: <url>to exist in the commits to be able to reference the PRremoving this outdated devDep also removes any remaining vulns in the devDeps
Future Work