Optimise performance of participant import #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, this PR is waiting for someone on team to be available to review and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed significant performance improvements when importing participants following this change.
Previously every import re-saved every participant in CiviCRM. For a big organisation you could therefore be looking at 500+ writes in one cron job. It's worth remembering that writes are significantly slower than reads on most databases.
This PR reads all the current participants for each event in bulk, and then only does writes where the participant data has actually changed (or is new).
This probably does increase memory usage, but in our testing significantly improves processing time, and so is a worthwhile tradeoff.