This repository was archived by the owner on Dec 2, 2021. It is now read-only.
Issue #11 - Cyclic dependency when defining job bean as prototype #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longwa
changed the title
|
Hi! Thanks for the contribution! Did the tests pass locally for you? I'll try to see whats going on with the tests later today. |
|
@erichelgeson Yeah, they are breaking locally. I'll dig into it. Sorry about that. I think I must've just run them with the first version of the fix. I can say that the fix does work in our real application so that's good at least. |
|
I see why the tests are broken, and my fix works fine on it's own but there must be some test pollution that's causing a few tests to break when run in full. I'm still chasing it down but it might be a day or two until I can finish up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.