[#106] Implement multi-connector #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I know the test cases are far below decency threshold, I want to make them better, but I wanted a validation on the idea before doing that. |
SpyQuel
reviewed
Jul 13, 2021
multi-connector/src/main/scala/it/agilelab/darwin/connector/multi/MultiConnectorCreator.scala
Show resolved
Hide resolved
multi-connector/src/main/scala/it/agilelab/darwin/connector/multi/MultiConnector.scala
Show resolved
Hide resolved
multi-connector/src/main/scala/it/agilelab/darwin/connector/multi/MultiConnector.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@SpyQuel I made a couple of changes, can you check if it covers your concerns? |
eliax1996
reviewed
Jul 18, 2021
eliax1996
left a comment
eliax1996
left a comment
There was a problem hiding this comment.
from what I have seen it all seems very good, the only thing is on the signature of the functions where you see that the multi-connector was not thought during the drafting of the interfaces. Sorry I ended up completing it on Sunday but I've been busy with a busy week :)
multi-connector/src/main/scala/it/agilelab/darwin/connector/multi/MultiConnector.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.