Skip to content

fix: revert golangci lint in makefile #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stefan-Ethernal merged 2 commits into from
Dec 30, 2025
Merged

fix: revert golangci lint in makefile #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3d0314
revert golangci-lint in Makefile
Stefan-Ethernal Dec 30, 2025
f8ed3b9
bump the linter version
Stefan-Ethernal Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v8.0.0
with:
version: v2.4.0
version: v2.7.2
args: --timeout=30m
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ check-curl: ## Check if curl is installed
# Check for Golangci-lint
.PHONY: check-golangci-lint
check-golangci-lint:
@which golangci-lint-v2 > /dev/null || (echo "Error: golangci-lint-v2 is not installed. Please install it: https://github.com/golangci/golangci-lint" && exit 1)
@which golangci-lint > /dev/null || (echo "Error: golangci-lint is not installed. Please install it: https://github.com/golangci/golangci-lint" && exit 1)

# Check for Swag
.PHONY: check-swag
Expand Down Expand Up @@ -98,7 +98,7 @@ test-unit: ## Runs the unit tests

.PHONY: lint
lint: ## Runs the linter
export "GOROOT=$$(go env GOROOT)" && $$(go env GOPATH)/bin/golangci-lint-v2 run --timeout 5m
export "GOROOT=$$(go env GOROOT)" && $$(go env GOPATH)/bin/golangci-lint run --timeout 5m

.PHONY: generate-swagger-docs
generate-swagger-docs: ## Generates the swagger docs
Expand Down
Loading