Skip to content

feat: Add L1 contract fallback check for missing GERs during L2GERSync #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rachit77 merged 7 commits into from
Nov 6, 2025
Merged

feat: Add L1 contract fallback check for missing GERs during L2GERSync #1265

rachit77 merged 7 commits into from
Nov 6, 2025

Conversation

@rachit77
Copy link
Contributor

@rachit77 rachit77 commented Nov 6, 2025 •
edited
Loading

🔄 Changes Summary

  • While syncing L2GERSync, if a GER is not found in L1InfoTreeSync despite it being up to date, verify on the L1 contract whether the GER exists and treat it as a fatal error if the GER is also missing from the L1 contract

📋 Config Updates

  • 🧾 Added GlobalExitRootL1Addr in [L2GERSync]

✅ Testing

  • 🤖 Automatic: [Optional: Enumerate E2E tests]
  • 🖱️ Manual: [Optional: Steps to verify]

🐞 Issues

  • Closes #[issue-number]

@rachit77 rachit77 self-assigned this Nov 6, 2025
temaniarpit27
temaniarpit27 reviewed Nov 6, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@temaniarpit27 temaniarpit27 marked this pull request as ready for review November 6, 2025 14:25
joanestebanr
joanestebanr reviewed Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@joanestebanr joanestebanr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to raise the coverage?

@rachit77
Copy link
Contributor Author

rachit77 commented Nov 6, 2025

Do you plan to raise the coverage?

3 lines of code are in log.fatal path and other 1 line is in constructor error path
So i don't think coverage can be raised any further in meaningful way

@rachit77 rachit77 merged commit 281e055 into develop Nov 6, 2025
21 of 22 checks passed
@rachit77 rachit77 deleted the fix-ger-check branch November 6, 2025 16:46
rachit77 added a commit that referenced this pull request Nov 6, 2025
@rachit77
feat: Add L1 contract fallback check for missing GERs during L2GERSync (
715262d 
#1265)

- While syncing L2GERSync, if a GER is not found in L1InfoTreeSync
despite it being up to date, verify on the L1 contract whether the GER
exists and treat it as a fatal error if the GER is also missing from the
L1 contract

- 🧾 Added `GlobalExitRootL1Addr` in `[L2GERSync]`

- 🤖 **Automatic**: [Optional: Enumerate E2E tests]
- 🖱️ **Manual**: [Optional: Steps to verify]

- Closes #[issue-number]
@rachit77 rachit77 mentioned this pull request Nov 6, 2025
Merged
rachit77 added a commit that referenced this pull request Nov 6, 2025
@rachit77
feat: cherry-pick add L1 contract fallback check for missing GERs dur…
a421ceb 
…ing L2GERSync (#1269)

## 🔄 Changes Summary
- Cherry pick #1265 

- 🧾 Added `GlobalExitRootL1Addr` in `[L2GERSync]`

## 🔗 Related PRs
- #1265
@rachit77 rachit77 mentioned this pull request Nov 7, 2025
Merged
rachit77 added a commit that referenced this pull request Nov 7, 2025
@rachit77
fix: address comments (#1274)
55dc81b 
## 🔄 Changes Summary
- This PR incorporates feedback received on PR
[here](#1265 (comment))


#1265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joanestebanr joanestebanr joanestebanr approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

@vcastellm vcastellm Awaiting requested review from vcastellm

+1 more reviewer

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachit77 rachit77

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rachit77 @temaniarpit27 @joanestebanr