varInspector close event fix
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agermanidis
reviewed
Oct 15, 2017
main.js
Outdated
| @@ -19,13 +19,17 @@ function openVariableInspector () { | |||
| protocol: "file:", | |||
| slashes: true | |||
| })); | |||
|
|
|||
| varInspector.on('close', () => { | |||
| // varInspector = null; | |||
There was a problem hiding this comment.
Is this supposed to be commented?
meain
force-pushed
the
bugfix-varinspector-close
branch
from
afa7e3e to
44bce1e
Compare
|
Oops. Fixed it. I have amended to the original commit to keep the git history clean. |
|
great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
varInspectoron close (using close button rather than 'v') event to set variable tonull