Skip to content

Conversation

@srilaasya
Copy link
Collaborator

📥 Pull Request

📘 Description
New tool to run SQL queries over postgres

🧪 Testing
tested local agentic workflow

#67

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 19.04762% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentstack/_tools/sql/__init__.py 5.55% 34 Missing ⚠️

📢 Thoughts on this report? Let us know!

@srilaasya srilaasya mentioned this pull request Jan 26, 2025
Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a handful of notes on this pr :)

@srilaasya
Copy link
Collaborator Author

Added tests for compile_llms_txt.py, fixed path in the workflow, db connection made private

@bboynton97
Copy link
Contributor

nice work!! did a little work to get it across the finish line but in general this was well done after the comments :)

@bboynton97 bboynton97 merged commit c82a30f into main Feb 14, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants