feat(core): implement agent skill#88
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
agentscope-core/src/main/java/io/agentscope/core/util/YamlFrontmatter.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR implements the agent skill feature as proposed by Anthropic, allowing agents to dynamically load specialized capabilities from skill directories. The implementation adds support for registering, managing, and using agent skills within the AgentScope framework.
- Adds comprehensive bilingual documentation (English and Chinese) explaining agent skill concepts, APIs, and usage examples
- Implements core agent skill functionality including YAML frontmatter parsing, skill registration, and integration with ReActAgent
- Provides complete test coverage for all new components including YamlFrontmatter parser, Toolkit agent skill APIs, and ToolRegistry operations
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/en/task/agent-skill.md | English documentation for agent skills with comprehensive examples and best practices |
| docs/zh/task/agent-skill.md | Chinese translation of agent skill documentation |
| agentscope-core/src/main/java/io/agentscope/core/util/YamlFrontmatter.java | New utility class for parsing YAML frontmatter from markdown files |
| agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java | Extended with agent skill registration, retrieval, and removal methods |
| agentscope-core/src/main/java/io/agentscope/core/tool/ToolkitConfig.java | Added configuration for agent skill instruction and template formatting |
| agentscope-core/src/main/java/io/agentscope/core/tool/ToolRegistry.java | Added concurrent map storage and operations for agent skills |
| agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java | Modified getSysPrompt() to append agent skill prompts automatically |
| agentscope-core/src/test/java/io/agentscope/core/util/YamlFrontmatterTest.java | Comprehensive test suite covering normal cases, edge cases, and error scenarios |
| agentscope-core/src/test/java/io/agentscope/core/tool/ToolkitTest.java | Tests for agent skill registration, validation, and removal |
| agentscope-core/src/test/java/io/agentscope/core/tool/ToolRegistryTest.java | Tests for registry operations including concurrent access |
| agentscope-core/src/test/java/io/agentscope/core/agent/test/TestConstants.java | Added default agent skill instruction and template constants |
| agentscope-core/src/test/java/io/agentscope/core/agent/ReActAgentTest.java | Integration test verifying agent skill prompt appending |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/test/java/io/agentscope/core/tool/ToolRegistryTest.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/util/YamlFrontmatter.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/test/java/io/agentscope/core/agent/ReActAgentTest.java
Outdated
Show resolved
Hide resolved
2ff8bd8 to
0fedfb6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/ToolRegistry.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/util/YamlFrontmatter.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/test/java/io/agentscope/core/agent/ReActAgentTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/test/java/io/agentscope/core/agent/ReActAgentTest.java
Outdated
Show resolved
Hide resolved
74a0aa6 to
643ecdb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
Outdated
Show resolved
Hide resolved
2c82e2e to
403d14a
Compare
37c5f0d to
940b32b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 33 out of 33 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
faa0e03 to
d842f6b
Compare
agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/skill/VersionedSkill.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/skill/SkillGroup.java
Outdated
Show resolved
Hide resolved
5c85fac to
6c21293
Compare
09a4288 to
eba411e
Compare
AlbumenJ
left a comment
There was a problem hiding this comment.
ReActAgentdoes not need to holdskillBox.- Extract
skillHookinto a separate class.
Others LGTM
903c9c5 to
1fba204
Compare
close #92