feat(training):support online training#703
feat(training):support online training#703qingTang0305 wants to merge 4 commits intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello @qingTang0305, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust online training extension for AgentScope Java, designed to facilitate continuous improvement of agents by integrating with the Trinity-RFT framework. It establishes a data feedback loop from production to training systems, enabling agents to learn and adapt from real-time interactions. The extension provides automated mechanisms for data collection, reward calculation, and training request management, aiming for a minimal setup experience for developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive online training extension, which is a significant and well-structured feature. The code is generally of high quality, with good use of reactive programming and clear separation of concerns. I've identified a few areas for improvement, primarily around error handling and documentation consistency, to make the new module more robust and easier to use.
...ope-extensions-training/src/main/java/io/agentscope/core/training/backend/TrinityClient.java
Outdated
Show resolved
Hide resolved
...ope-extensions-training/src/main/java/io/agentscope/core/training/backend/TrinityClient.java
Outdated
Show resolved
Hide resolved
...ope-extensions-training/src/main/java/io/agentscope/core/training/runner/TrainingRouter.java
Show resolved
Hide resolved
...ope-extensions-training/src/main/java/io/agentscope/core/training/backend/TrinityClient.java
Outdated
Show resolved
Hide resolved
...ope-extensions-training/src/main/java/io/agentscope/core/training/backend/TrinityClient.java
Outdated
Show resolved
Hide resolved
...ope-extensions-training/src/main/java/io/agentscope/core/training/backend/TrinityClient.java
Outdated
Show resolved
Hide resolved
1f9ef26 to
be51560
Compare
Change-Id: I18eb3c8b75051569833fb9e4a6c3a3b2d6855c2c
Change-Id: I02e03641c44e51d576bfd7901706b9237d6844a4
be51560 to
9be3eb0
Compare
Change-Id: Ia388f09600ef9547ab2fe16d595ff01a4ed4dca1
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.8, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
feat(training):#702
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)