fix(core):Add the correct reason for the stop agent behavior(#602)#606
fix(core):Add the correct reason for the stop agent behavior(#602)#606AlbumenJ merged 2 commits intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello @feelshana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a fix in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of missing reasons for agent stops. The changes in ReActAgent.java now properly set the GenerateReason to REASONING_STOP_REQUESTED and ACTING_STOP_REQUESTED when a stop is requested during the respective phases. This provides better observability into the agent's execution flow. The implementation is clean, uses the existing withGenerateReason method correctly, and aligns with the framework's design. The changes are accurate and improve the overall quality of the code.
bb6aedb to
1497a10
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ope-ai#606) ## AgentScope-Java Version main branch ## Description Add the correct reason for the stop agent behavior(agentscope-ai#602) ## Checklist Please check the following items before code is ready to be reviewed. - [ ] Code has been formatted with `mvn spotless:apply` - [ ] All tests are passing (`mvn test`) - [ ] Javadoc comments are complete and follow project conventions - [ ] Related documentation has been updated (e.g. links, examples, etc.) - [ ] Code is ready for review
AgentScope-Java Version
main branch
Description
Add the correct reason for the stop agent behavior(#602)
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)