chore(dependency): Exclude lombok to compatible with jdk25#604
chore(dependency): Exclude lombok to compatible with jdk25#604AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello @guanxuc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility issue with JDK25 by explicitly excluding the Lombok dependency from several key modules. This change prevents a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request excludes the lombok dependency to ensure compatibility with JDK 25. The changes correctly address the issue by adding exclusions in the pom.xml files. However, there are opportunities for improvement regarding dependency management best practices. Specifically, the exclusion is duplicated across multiple modules, and one of the exclusions is redundant. My review includes suggestions to centralize the dependency exclusion for better maintainability and to remove the unnecessary exclusion.
e2f90f7 to
5f4b9eb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…e-ai#604) ## AgentScope-Java Version 1.0.8 ## Description * Exclude lombok to compatible with jdk25. * When use the low level lombok and jdk25 will cause the error as the follow, btw, lombok should not be passed on. ```java java: java.lang.ExceptionInInitializerError com.sun.tools.javac.code.TypeTag :: UNKNOWN java: java.lang.ExceptionInInitializerError ``` ## Checklist Please check the following items before code is ready to be reviewed. - [x] Code has been formatted with `mvn spotless:apply` - [x] All tests are passing (`mvn test`) - [x] Javadoc comments are complete and follow project conventions - [x] Related documentation has been updated (e.g. links, examples, etc.) - [x] Code is ready for review
AgentScope-Java Version
1.0.8
Description
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)