chore(distribution): add missing jackson-datatype-jsr310 dependency to agentscope-all#507
Merged
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom Jan 12, 2026
Conversation
The dependency was added to agentscope-core but not synced to agentscope-all, causing NoClassDefFoundError for users of the all-in-one artifact.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing dependency issue where jackson-datatype-jsr310 was added to agentscope-core but not synchronized to the all-in-one distribution artifact agentscope-all. Since agentscope-core is marked as optional in agentscope-all, its transitive dependencies don't propagate to downstream users, causing NoClassDefFoundError at runtime.
Changes:
- Added
jackson-datatype-jsr310dependency toagentscope-all/pom.xmlto fix transitive dependency propagation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fang-tech
changed the title
AlbumenJ
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #506
AgentScope-Java Version
1.0.7-SNAPSHOT
Description
The dependency was added to agentscope-core but not synced to agentscope-all, causing NoClassDefFoundError for users of the all-in-one artifact.
Root Cause
The
jackson-datatype-jsr310dependency was added toagentscope-corein commit 5f19549 (#413), but was not synchronized toagentscope-all/pom.xml.Since
agentscope-coreis declared with<optional>true</optional>inagentscope-all, its transitive dependencies are not propagated to downstream users.Solution
Add the missing
jackson-datatype-jsr310dependency toagentscope-distribution/agentscope-all/pom.xml.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)