fix: Correct output attribute after callTool responded.#443
fix: Correct output attribute after callTool responded.#443AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR corrects a bug where the wrong attribute key was used when extracting tool response attributes for OpenTelemetry tracing. The method getToolResponseAttributes was incorrectly using AGENTSCOPE_FUNCTION_INPUT instead of AGENTSCOPE_FUNCTION_OUTPUT.
Key Changes:
- Fixed attribute key in
getToolResponseAttributesfrom INPUT to OUTPUT, aligning with the established pattern where request methods useAGENTSCOPE_FUNCTION_INPUTand response methods useAGENTSCOPE_FUNCTION_OUTPUT
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.5, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)