Skip to content

fix: Correct output attribute after callTool responded.#443

Merged
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
alickreborn0:fix-tracing
Jan 5, 2026
Merged

fix: Correct output attribute after callTool responded.#443
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
alickreborn0:fix-tracing

Conversation

@alickreborn0
Copy link
Contributor

AgentScope-Java Version

[The version of AgentScope-Java you are working on, e.g. 1.0.5, check your pom.xml dependency version or run mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@alickreborn0 alickreborn0 requested review from a team and Copilot January 5, 2026 02:18
@cla-assistant
Copy link

cla-assistant bot commented Jan 5, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Jan 5, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a bug where the wrong attribute key was used when extracting tool response attributes for OpenTelemetry tracing. The method getToolResponseAttributes was incorrectly using AGENTSCOPE_FUNCTION_INPUT instead of AGENTSCOPE_FUNCTION_OUTPUT.

Key Changes:

  • Fixed attribute key in getToolResponseAttributes from INPUT to OUTPUT, aligning with the established pattern where request methods use AGENTSCOPE_FUNCTION_INPUT and response methods use AGENTSCOPE_FUNCTION_OUTPUT

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit b75e532 into agentscope-ai:main Jan 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants