Skip to content

fix(agui): handle TextBlock in last REASONING event correctly#419

Merged
AlbumenJ merged 3 commits intoagentscope-ai:mainfrom
Howryann:tool-call-start-missing
Jan 3, 2026
Merged

fix(agui): handle TextBlock in last REASONING event correctly#419
AlbumenJ merged 3 commits intoagentscope-ai:mainfrom
Howryann:tool-call-start-missing

Conversation

@Howryann
Copy link
Contributor

@Howryann Howryann commented Jan 1, 2026 •
edited
Loading

AgentScope-Java Version

1.0.6-SNAPSHOT

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@Howryann Howryann requested a review from a team January 1, 2026 06:44
@cla-assistant
Copy link

cla-assistant bot commented Jan 1, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...agentscope/core/agui/adapter/AguiAgentAdapter.java 66.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

AlbumenJ
AlbumenJ requested changes Jan 3, 2026
View reviewed changes
Copy link
Collaborator

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM
But, the title doesn't match the changes

@Howryann Howryann changed the title fix(agui): emit TOOL_CALL_START for ToolUseBlock in last REASONING event fix(agui): handle TextBlock in last REASONING event correctly Jan 3, 2026
@Howryann
Copy link
Contributor Author

Howryann commented Jan 3, 2026

Fixed, thanks!

@Howryann Howryann requested a review from AlbumenJ January 3, 2026 08:21
@AlbumenJ AlbumenJ merged commit 0ced527 into agentscope-ai:main Jan 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: AG-UI adapter emits TOOL_CALL_END without TOOL_CALL_START/ARGS

2 participants

@Howryann @AlbumenJ