Skip to content

feat(model): Explicitly assign value for thinking mode and search mode#380

Merged
AlbumenJ merged 3 commits intoagentscope-ai:mainfrom
guanxuc:explicitly-assign
Dec 29, 2025
Merged

feat(model): Explicitly assign value for thinking mode and search mode#380
AlbumenJ merged 3 commits intoagentscope-ai:mainfrom
guanxuc:explicitly-assign

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Dec 27, 2025

AgentScope-Java Version

1.0.5-SNAPSHOT

Description

Explicitly assign value for thinking mode and search mode

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team December 27, 2025 16:27
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...a/io/agentscope/core/model/DashScopeChatModel.java 83.33% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@AlbumenJ
Copy link
Collaborator

Please add some ut

@guanxuc
Copy link
Contributor Author

guanxuc commented Dec 28, 2025

Please add some ut

@AlbumenJ I've added unit tests with reflection.

@AlbumenJ AlbumenJ merged commit bff158d into agentscope-ai:main Dec 29, 2025
4 checks passed
@guanxuc guanxuc deleted the explicitly-assign branch December 29, 2025 03:46
JGoP-L pushed a commit to JGoP-L/agentscope-java that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants