Skip to content

fix(core): Missing error handling for SSE response#359

Merged
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
guanxuc:check-error-sse
Dec 25, 2025
Merged

fix(core): Missing error handling for SSE response#359
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
guanxuc:check-error-sse

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Dec 25, 2025

AgentScope-Java Version

1.0.4-SNAPSHOT

Description

Add error handling for SSE response.

Checklist

Please check the following items before code is ready to be reviewed.

  •   Code has been formatted with mvn spotless:apply
  •   All tests are passing (mvn test)
  •   Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  •   Code is ready for review

@guanxuc guanxuc requested a review from a team December 25, 2025 08:50
@guanxuc guanxuc changed the title fix(core): Missing error check for SSE response fix(core): Missing error handling for SSE response Dec 25, 2025
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../io/agentscope/core/model/DashScopeHttpClient.java 87.50% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit 7db33b5 into agentscope-ai:main Dec 25, 2025
4 checks passed
@guanxuc guanxuc deleted the check-error-sse branch December 25, 2025 13:06
JGoP-L pushed a commit to JGoP-L/agentscope-java that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants