Skip to content

feat(rag): add HayStack RAG Integration#268

Merged
AlbumenJ merged 11 commits intoagentscope-ai:mainfrom
Akika404:feature/haystack-rag-integration
Dec 26, 2025
Merged

feat(rag): add HayStack RAG Integration#268
AlbumenJ merged 11 commits intoagentscope-ai:mainfrom
Akika404:feature/haystack-rag-integration

Conversation

@Akika404
Copy link
Contributor

@Akika404 Akika404 commented Dec 20, 2025

AgentScope-Java Version

1.0.4-SNAPSHOT

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@cla-assistant
Copy link

cla-assistant bot commented Dec 20, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Dec 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Akika404
Copy link
Contributor Author

Akika404 commented Dec 20, 2025

[WIP] SentenceWindowRetriever is not supported yet; Related to the contextWindows and contextDocuments properties in HayStackResponse.

SentenceWindowRetriever is now supported.

@Akika404 Akika404 force-pushed the feature/haystack-rag-integration branch from af1e4e1 to 9f2648a Compare December 24, 2025 14:30
@Akika404 Akika404 marked this pull request as ready for review December 24, 2025 15:53
@Akika404 Akika404 requested a review from a team December 24, 2025 15:53
@Akika404
Copy link
Contributor Author

@AlbumenJ hi, I've submitted a PR to complete this feature.
I'd appreciate a review when you have time.
Please let me know if there's anything I can improve. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a comprehensive HayStack RAG integration to AgentScope-Java, enabling support for HayStack-based knowledge base retrieval alongside existing RAG providers (Dify, RAGFlow, Bailian, etc.).

Key Changes:

  • New HayStack RAG extension module with client, configuration, and knowledge base implementation
  • Support for both standard retrieval and SentenceWindowRetriever response formats
  • Comprehensive test coverage with unit tests and mock server testing
  • Documentation updates in both English and Chinese

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
docs/en/quickstart/installation.md Added HayStack RAG to the dependency table for English documentation
docs/zh/quickstart/installation.md Added HayStack RAG to the dependency table for Chinese documentation
agentscope-extensions/pom.xml Added haystack module to extensions parent POM
agentscope-extensions/agentscope-extensions-rag-haystack/pom.xml New module POM with OkHttp, Jackson, and Reactor dependencies
HayStackConfig.java Configuration class with retrieval parameters, filters, and HTTP settings
HayStackClient.java HTTP client implementation with retry logic and reactive API
HayStackKnowledge.java Main integration implementing Knowledge interface for RAG operations
HayStackDocumentConverter.java Utility for converting HayStack documents to AgentScope format
HayStackApiException.java Custom exception for HayStack API errors
Model classes (HayStackDocument, HayStackResponse, etc.) Data models for API communication
FilterPolicy.java Enum for filter merge/replace policies
Test files Comprehensive unit tests for all components with MockWebServer
HayStackRAGExample.java Example demonstrating integration with ReActAgent
agentscope-distribution POMs Added haystack module to BOM and all-in-one distribution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Akika404 Akika404 force-pushed the feature/haystack-rag-integration branch from 6b7358d to 0b334bb Compare December 25, 2025 13:59
@Akika404 Akika404 changed the title feat: add HayStack RAG Integration feat(rag): add HayStack RAG Integration Dec 25, 2025
@AlbumenJ AlbumenJ merged commit e23ee1e into agentscope-ai:main Dec 26, 2025
4 checks passed
@Akika404 Akika404 deleted the feature/haystack-rag-integration branch December 26, 2025 07:15
JGoP-L pushed a commit to JGoP-L/agentscope-java that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants