fix(harness): inherit memory config in subagents - #2611
Open
steven-ji wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
steven-ji
marked this pull request as ready for review
August 7, 2026 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
Fixes #2549.
Background and root cause
Automatically built subagents inherited the parent agent's memory enable/disable flags, but both
buildGeneralPurposeFactory(...)andbuildDeclaredFactory(...)omitted the parent'sMemoryConfig. Their child builders therefore fell back toMemoryConfig.defaults(), which could trigger unexpected flush/consolidation model calls and ignore custom memory prompts, retention settings, and model overrides.Changes
MemoryConfigto general-purpose subagents.FlushTrigger.never()and verify that a child call performs only the normal model invocation, with no unexpected memory flush call.This PR is intentionally limited to configuration inheritance. Broader asynchronous memory-maintenance latency is outside its scope.
Validation
mvn -pl agentscope-harness -am -Dtest=HarnessAgentTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl agentscope-harness -am -Djava.awt.headless=true testagentscope-core: 2264 tests, 0 failures, 0 errorsagentscope-harness: 786 tests, 0 failures, 0 errorsgit diff --checkChecklist
mvn spotless:apply