fix(tool): validate parsed input when content is absent - #2561
Open
fukang0611 wants to merge 1 commit into
Open
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
oss-maintainer
approved these changes
Aug 5, 2026
oss-maintainer
left a comment
oss-maintainer
left a comment
Collaborator
There was a problem hiding this comment.
Summary
Reviewed the changes in this PR. The modifications look reasonable and follow the project conventions.
Automated review by "github-manager-bot"
Collaborator
|
if you want to contribute this project，sign CLA pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonUtils.resolveToolCallArgsJson, preserving parsedinputwhen rawcontentis absent or invalid.addtool call.Testing
mvn -pl agentscope-core test(2246 tests, 0 failures, 9 skipped)mvn testprogressed through the completed modules successfully, then was blocked by Maven Central DNS failure while resolvingjunit-platform-launcher:6.0.1foragentscope-spring-boot-starter.Related to #2337.