Skip to content

fix(rag): Missing the dimension parameter for embedding#188

Merged
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
guanxuc:fix-embedding-dashscope
Dec 12, 2025
Merged

fix(rag): Missing the dimension parameter for embedding#188
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
guanxuc:fix-embedding-dashscope

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Dec 12, 2025

AgentScope-Java Version

1.0.3-SNAPSHOT

Description

  • Add the dimension parameter for embedding.
  • Set the default value of the dimension parameter to 1024 if not specified.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

- Add the dimension parameter for embedding.
- Set the default value of the dimension parameter to 1024 if not specified.
@guanxuc guanxuc requested a review from a team December 12, 2025 10:05
@cla-assistant
Copy link

cla-assistant bot commented Dec 12, 2025

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...edding/dashscope/DashScopeMultiModalEmbedding.java 33.33% 2 Missing ⚠️
...re/embedding/dashscope/DashScopeTextEmbedding.java 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit 53a0731 into agentscope-ai:main Dec 12, 2025
3 of 4 checks passed
@guanxuc guanxuc deleted the fix-embedding-dashscope branch December 12, 2025 13:00
JGoP-L pushed a commit to JGoP-L/agentscope-java that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants