Code Review Bench PR #14058 - Add auto-repair options for broken AOF tail on startup#7
Open
tomerqodo wants to merge 22 commits intobase_pr_14058_20260125_2675from
Open
Code Review Bench PR #14058 - Add auto-repair options for broken AOF tail on startup#7tomerqodo wants to merge 22 commits intobase_pr_14058_20260125_2675from
tomerqodo wants to merge 22 commits intobase_pr_14058_20260125_2675from
Conversation
This was referenced Jan 26, 2026
Open
This was referenced Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Bench PR redis#14058
Original PR Title: Add auto-repair options for broken AOF tail on startup
Original PR Description: When Redis is shut down uncleanly (e.g., due to power loss), invalid bytes may remain at the end of the AOF file. Currently, Redis detects such corruption only after parsing most of the AOF, leading to delayed error detection and increased downtime. Manual recovery via
redis-check-aof --fixis also time-consuming.This fix introduces two new options to improve resilience and reduce downtime:
aof-load-broken: Enables automatic detection and repair of broken AOF tails.aof-load-broken-max-size: Sets a maximum threshold (in bytes) for the corrupted tail size that Redis will attempt to fix automatically without requiring user intervention.Original PR URL: redis#14058