Code Review Bench PR #14646 - Replace fragile dict stored-key API with getKeyId callback#1
Open
tomerqodo wants to merge 2 commits intobase_pr_14646_20260125_7845from
Open
Conversation
This was referenced Jan 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Bench PR redis#14646
Original PR Title: Replace fragile dict stored-key API with getKeyId callback
Original PR Description: ## Summary
getKeyIdcallback approach.with the sds field at the start. Since both stored keys (Entry*) and lookup keys
(sds) can now be trivially compared as sds strings, first two commits starts with cleanups of dictUseStoredKeyApi() for hash data type.
dict API Changes
storedHashFunction,storedKeyComparecallbacks anddictUseStoredKeyApi()flagdictType.keyFromStoredKeycallback that extracts the key identifier from stored objectsNo performance impact.
Original PR URL: redis#14646