Code Review Bench PR #26717 - refactor: Remove trpc/server dependency from @calcom/atoms#15
Open
tomerqodo wants to merge 2 commits intobase_pr_26717_20260125_4345from
Open
Conversation
This was referenced Jan 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Bench PR calcom#26717
Original PR Title: refactor: Remove trpc/server dependency from @calcom/atoms
Original PR Description: ## What does this PR do?
trpc/serverImpact
Summary of Changes
Type Migrations:
Slottype to@calcom/atoms/booker/types(removed from trpc/server)GetAvailableSlotsResponsetype withSlotInfotobooker/types.tshooks/schedules/types.ts:Schedule(withuserIdfor create/duplicate handlers)CreateScheduleHandlerReturn,DuplicateScheduleHandlerReturn,GetAvailabilityListHandlerReturnCreateScheduleInputImport Updates:
useAtomCreateSchedule,useAtomDuplicateSchedule,useAtomGetAllSchedulesto use local typesuseAvailableSlots.tsto use localGetAvailableSlotsResponseConfig Changes:
@calcom/trpcimports (not just@calcom/trpc/react)tsconfig.jsonpackage.jsonexportsUpdates since last revision
GetAvailabilityListHandlerReturntype: wrapped intersection type in parentheses so[]creates an array of the intersection type rather than an intersection with an array type (addresses Cubic AI review feedback)Mandatory Tasks (DO NOT REMOVE)
Original PR URL: calcom#26717