fix(api): return original email without OAuth suffix in bookings

[tomerqodo]

Benchmark PR from agentic-review-benchmarks#4

Summary by CodeRabbit

Release Notes

• New Features

  • Added displayEmail field to booking API responses for attendees, hosts, and reassignments.

• Tests

  • Updated multiple end-to-end tests to validate the new displayEmail field in booking responses across various booking scenarios.

• Documentation

  • Updated API schema definitions for booking outputs to include the new displayEmail property.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A new displayEmail field is introduced across booking APIs to provide a sanitized version of email addresses by removing plus-address suffixes. The feature includes type definitions, service implementation, OpenAPI schema updates, and comprehensive e2e test coverage validating the field across various booking workflows.

Changes

Cohort / File(s)	Summary
Configuration .github/oasdiff-err-ignore.txt	Added ignore rules for schema validation errors related to new displayEmail field in various booking endpoints across POST/GET operations.
Type Definitions packages/platform/types/bookings/2024-08-13/outputs/booking.output.ts	Added displayEmail: string property to BookingAttendee, BookingHost, and ReassignedToDto classes; introduced static cleanEmailForDisplay() helper method to strip plus-address suffixes.
Service Implementation apps/api/v2/src/ee/bookings/2024-08-13/services/output.service.ts	Implemented private getDisplayEmail() helper and propagated displayEmail field through multiple booking output transformation paths including attendees, hosts, guests, and reassignment responses.
OpenAPI Schema docs/api-reference/v2/openapi.json	Extended booking, scheduling, webhook, calendar, and organizational schemas with displayEmail property on attendees and hosts; added comprehensive schedule, webhook, calendar integration, and role management schemas.
Booking E2E Tests apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/api-key-bookings.e2e-spec.ts, managed-user-bookings.e2e-spec.ts, reassign-bookings.e2e-spec.ts, recurring-bookings.e2e-spec.ts, seated-bookings.e2e-spec.ts, team-bookings.e2e-spec.ts, user-bookings.e2e-spec.ts	Updated test assertions across multiple e2e test suites to validate displayEmail field in attendee objects, reassignment responses, and booking field responses across various booking scenarios.
Organization E2E Tests apps/api/v2/src/modules/organizations/bookings/organizations-bookings.controller.e2e-spec.ts, organizations-teams-bookings.controller.e2e-spec.ts, organizations-users-bookings.e2e-spec.ts	Added displayEmail field assertions in organization-level booking test cases for standard, team, and user-scoped booking creation endpoints.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A hop through emails with a cleaner display,
We strip those plus-tags that clutter the way,
From tests to schemas, the field now takes flight,
displayEmail gleams, shining pixel-bright!
The data flows pure through each booking's delight! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(api): return original email without OAuth suffix in bookings' directly and clearly describes the main change: adding displayEmail fields to booking responses that provide clean email addresses without OAuth suffixes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hussam789]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.