fix(profile): use correct config path and merge seatbelt rules#28
Merged
fix(profile): use correct config path and merge seatbelt rules#28
Conversation
- Fix profile loader path: use ~/.config/sx/profiles/ instead of dirs::config_dir() (which resolves to ~/Library/Application Support on macOS, breaking profile loading) - Add seatbelt raw rule merging: compose_profiles() now concatenates raw seatbelt rules from all profiles instead of silently dropping them - Merge resolution: kept both ExecSugid union-merge and seatbelt rule concatenation logic in compose_profiles()
Pierozi
changed the title
- Add [seatbelt] raw rules section to PROFILES.md and CONFIGURATION.md - Document profile resolution order (builtin → project dir → ~/.config/sx/profiles/) - Add seatbelt concatenation to merging rules - Update README to reference custom profile capabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/sx/profiles/instead ofdirs::config_dir()which resolves to~/Library/Application Supporton macOS, mismatching the convention inglobal.rscompose_profiles()to concatenate seatbelt raw rules from all profiles instead of silently dropping them[seatbelt]raw rules, profile resolution order, and merging semanticsTest plan
test_compose_profiles_seatbelt_single— single profile preserves raw rulestest_compose_profiles_seatbelt_concatenation— multiple profiles concatenate raw rulestest_compose_profiles_seatbelt_none_skipped— profiles without seatbelt don't clobber existing rules