-
Notifications
You must be signed in to change notification settings - Fork 4
upgrade-enclave #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade-enclave #229
Conversation
📝 WalkthroughWalkthroughUpdated dependency names and versions and adjusted related imports/configs: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@libs/uipack/package.json`:
- Line 65: The import in libs/uipack/src/bundler/sandbox/enclave-adapter.ts
currently pulls Enclave, CreateEnclaveOptions, and SecurityLevel from the old
package name; update the import statement to use the scoped package
'@enclave-vm/core' so the symbols Enclave, type CreateEnclaveOptions, and type
SecurityLevel are imported from '@enclave-vm/core' instead of 'enclave-vm'.
In `@package.json`:
- Line 39: Update source imports and Jest configs to match the package rename to
`@enclave-vm/core`: in libs/uipack/src/bundler/sandbox/enclave-adapter.ts change
the import line that reads "import { Enclave, type CreateEnclaveOptions, type
SecurityLevel } from 'enclave-vm'" to import those same symbols from
'@enclave-vm/core'; in plugins/plugin-codecall/src/services/enclave.service.ts
change "import { Enclave, type ExecutionResult, type ToolHandler, type
ReferenceSidecarOptions } from 'enclave-vm'" to import from '@enclave-vm/core';
and update any jest.config.ts transformIgnorePatterns entries that reference
'enclave-vm' to '@enclave-vm/core' so tests resolve the renamed package.
In `@plugins/plugin-codecall/package.json`:
- Around line 49-50: Update all import usages of the old package name to the new
one: in enclave.service.ts replace any import specifier string 'enclave-vm' with
'@enclave-vm/core' so the module resolution matches package.json, and in
jest.config.ts update the transformIgnorePatterns regex to reference
'@enclave-vm/core' instead of 'enclave-vm' so tests don’t ignore the new package
during transformation.
Performance Test ResultsStatus: ✅ All tests passed Summary
Total: 100 tests across 21 projects 📊 View full report in workflow run Generated at: 2026-02-03T06:12:35.330Z |
…nced output sanitization
Summary by CodeRabbit
New Features
Chores
Documentation
Tests/Tooling