Skip to content

Conversation

@frontegg-david
Copy link
Contributor

@frontegg-david frontegg-david commented Jan 15, 2026

Summary by CodeRabbit

  • Chores
    • Updated test environment configuration to improve remote gateway testing setup.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Added the LOCAL_MCP_PORT environment variable (set to 3099) to the e2e test configuration, enabling the remote gateway to connect with a locally-running MCP server instance.

Changes

Cohort / File(s) Summary
E2E Test Configuration
apps/e2e/demo-e2e-remote/e2e/remote.e2e.test.ts
Set LOCAL_MCP_PORT=3099 environment variable in test setup to configure remote gateway MCP port connectivity

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A port to bind, a gateway aligned,
LOCAL_MCP_PORT in the test we find,
3099 now hops with glee,
Remote and local in harmony! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: setting LOCAL_MCP_PORT environment variable for local MCP server connectivity in e2e tests, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2eb32d0 and 8e3118e.

📒 Files selected for processing (1)
  • apps/e2e/demo-e2e-remote/e2e/remote.e2e.test.ts
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Use strict TypeScript mode with no any types without strong justification
Avoid non-null assertions (!) - use proper error handling and type guards instead
Use @frontmcp/utils for cryptographic operations instead of node:crypto directly
Use @frontmcp/utils for file system operations instead of fs/promises or node:fs directly

Files:

  • apps/e2e/demo-e2e-remote/e2e/remote.e2e.test.ts
**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.test.{ts,tsx}: Achieve 95%+ test coverage across all metrics (statements, branches, functions, lines)
Use Jest for testing with 95%+ coverage requirement and 100% test pass rate
Do not use prefixes like 'PT-001' in test names
Do not skip constructor validation tests for error classes and types
Include instanceof checks in tests for error classes to verify proper error hierarchy

Files:

  • apps/e2e/demo-e2e-remote/e2e/remote.e2e.test.ts
apps/**

⚙️ CodeRabbit configuration file

apps/**: apps/** directory contains a demo application for testing purposes. It can be used as a reference for SDK usage examples.

Files:

  • apps/e2e/demo-e2e-remote/e2e/remote.e2e.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint & Format Checks
  • GitHub Check: Build Libraries
  • GitHub Check: Package E2E (Verdaccio)
🔇 Additional comments (1)
apps/e2e/demo-e2e-remote/e2e/remote.e2e.test.ts (1)

55-62: LGTM! Port configuration is consistent.

The LOCAL_MCP_PORT environment variable correctly matches the port (3099) where the local MCP server is started in beforeAll (line 27), ensuring proper gateway-to-local-server connectivity.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@frontegg-david frontegg-david merged commit f62b790 into release/0.8.x Jan 15, 2026
22 checks passed
@frontegg-david frontegg-david deleted the fix-remote-mcp-test branch January 15, 2026 18:57
github-actions bot pushed a commit that referenced this pull request Jan 15, 2026
…rver connectivity tests

Cherry-picked from #214 (merged to release/0.8.x)
Original commit: f62b790

Co-Authored-By: frontegg-david <69419539+frontegg-david@users.noreply.github.com>
@github-actions
Copy link
Contributor

Cherry-pick Created

A cherry-pick PR to main has been automatically created.

Please review and merge if this change should also be in main.

If the cherry-pick is not needed, close the PR.

frontegg-david added a commit that referenced this pull request Jan 16, 2026
…rver connectivity tests (#215)

Cherry-picked from #214 (merged to release/0.8.x)
Original commit: f62b790

Co-authored-by: agentfront[bot] <agentfront[bot]@users.noreply.github.com>
Co-authored-by: frontegg-david <69419539+frontegg-david@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants