Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/pr-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ jobs:
with:
go-version-file: 'go.mod'
- run: go test -v ./...
# The imagecache consumer half (overlay mounts, whiteout mknod, trusted.*

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should generalize rootful "integration" tests as a follow-up TODO.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — filed #501 to generalize rootful test execution (discovery via build tag/convention + a single sudo step, plus contributor docs), so this per-package step becomes the first consumer rather than a pattern.

# xattrs) is guarded by root-only tests that skip for the unprivileged
# runner user above; run that one package again as root so they execute.
- name: imagecache privileged tests
run: sudo -E env "PATH=$PATH" go test -v -count=1 ./internal/imagecache/
- name: verify
run: hack/verify-all.sh
# One kind cluster exercises BOTH runtimes. Free x86-64 ubuntu-latest runners
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@ Thumbs.db

# Local worktrees
/.worktrees/

# Stray local build outputs (go build ./tools/... without -o)
/validate-image-cache
235 changes: 0 additions & 235 deletions cmd/atelet/internal/memorypullcache/memorypullcache.go

This file was deleted.

84 changes: 0 additions & 84 deletions cmd/atelet/internal/memorypullcache/memorypullcache_test.go

This file was deleted.

Loading
Loading