Repository navigation
Keep the file owners an image's layers record inside the actor - #2392
Open
Anish Ramasekar (aramase) wants to merge 8 commits into
Open
Anish Ramasekar (aramase) wants to merge 8 commits into
Anish Ramasekar (aramase) wants to merge 8 commits into
Conversation
…s other users own
Anish Ramasekar (aramase)
marked this pull request as ready for review
October 9, 2026 06:28
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/substrate
that referenced
this pull request
Oct 9, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image layers record an owner for every file, but atelet's unpack only applied the mode, so everything showed up as
0:0inside the actor. Once actors run as the image'sUSER(#1918), they can't read their own home directory.CAP_CHOWN, so atelet gets it.Breaking change
Please add the
breaking-changelabel.docs/upgrade.md).DAC_OVERRIDEcan't write image files other users own; the jupyter demo now adds it.Tested with root unit tests on Linux (also with only atelet's capabilities), the new
imagefse2e on kind with gVisor (fails on main, passes here), andmake teston Linux.Fixes #2036