Repository navigation
benchmarking: add memory working set to server telemetry - #2386
Open
Nishanth Kotla (Nishanth29) wants to merge 4 commits into
Open
Nishanth Kotla (Nishanth29) wants to merge 4 commits into
Nishanth Kotla (Nishanth29) wants to merge 4 commits into
Conversation
They pooled every atelet's samples, so they were cluster level and duplicated summary. True per-atelet stats will come in a follow-up.
Contributor
Author
2 tasks done
Contributor
Author
|
Da Huang (@git286) Tim Bai (@baizhenyu), adding you as reviewers. For actors this only reads your existing ate.actor.stats.memory.working_set and ate.actor.stats.sampled_actors (no new metrics); node/ateom/atelet come from cAdvisor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2221. The first 3 commits are #2221's; this PR's change is only the last commit, 36d26077 ("benchmarking: add memory working set to server telemetry"). Will rebase once #2221 merges.
Part of #1590
Adds
working_setto server telemetry:node,ateom,atelet: from cAdvisor (container_memory_working_set_bytes).actor,per_actor: reuse the atelet's existing actor stats metrics,ate_actor_stats_memory_working_set_bytesandate_actor_stats_sampled_actors.actoris the actors' working set per atelet;per_actordivides it bythe number of actors that atelet measured.
Both sources are already collected (cAdvisor and the atelet), so nothing changes in Substrate or the monitoring setup; this only adds queries.
Live check (gVisor, 4 users, 3m, through the telemetry-meter):
actor 1.13 GiB vs ateom 1.22 GiB at the same time
per_actor × count = actor (0.5628 × 2 = 1.1257)
74 measurements, none null
Tests pass
Appropriate changes to documentation are included in the PR